Fix flaky integ test caused by latency of undeploy model #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhichao-aws <[email protected]>
zhichao-aws
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
wujunshen,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
Signed-off-by: zhichao-aws <[email protected]>
zane-neo
approved these changes
Sep 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
=========================================
Coverage 84.56% 84.56%
Complexity 427 427
=========================================
Files 35 35
Lines 1289 1289
Branches 189 189
=========================================
Hits 1090 1090
Misses 118 118
Partials 81 81 |
navneet1v
approved these changes
Sep 27, 2023
|
@zane-neo does this change needs to be backported? |
Yes, let's backport this. |
zane-neo
added
the
backport 2.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-345-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 67ced0d0b9f1725b150721156481abc86fee3020
# Push it to GitHub
git push --set-upstream origin backport/backport-345-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
zane-neo
pushed a commit
to zane-neo/neural-search
that referenced
this pull request
Sep 28, 2023
…project#345) * add 3s sleep before delete model Signed-off-by: zhichao-aws <[email protected]> * remove print stack trace Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit 67ced0d)
zane-neo
added a commit
to zane-neo/neural-search
that referenced
this pull request
Sep 28, 2023
…model (opensearch-project#345) Signed-off-by: zane-neo <[email protected]>
5 tasks
navneet1v
pushed a commit
that referenced
this pull request
Sep 28, 2023
…model (#345) (#352) Signed-off-by: zane-neo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For ml-commons plugin, after model undeploy returns, the max interval to update model status is 3s in ml-commons CronJob. This can cause flaky integ test in neural-search plugin. Add 3s sleep to fix this.
example: https://github.com/opensearch-project/neural-search/actions/runs/6321926472/job/17166662817
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.